Cleanup irc.mod / string copy

[michaelortmann]

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Cleanup irc.mod / string copy

Additional description (if needed):
Some got-functions in chan.c and irc.mod did an unnecessary string copy.

Test cases demonstrating functionality (if applicable):
No functional change.

[thommey]

This isn't a simple cleanup, it's a change in behavior. newsplit modifies its argument string to split it, removing this buffer makes the functions modify the input.

[michaelortmann]

thats fine. the parameter is modifyable. we dont need to copy before newsplit(). other functions in chan.c call newsplit() on the parameter without such copy also. example: https://github.com/eggheads/eggdrop/blob/develop/src/mod/irc.mod/chan.c#L1192

[thommey]

It still has side-effects I have seen in the past, e.g. raw console log being mangled.
It might be warranted to always give the bind handler a copy of this string instead of the real raw string.