Remove the limit of 1024 chars for input/output of add_cr() and escape_telnet() #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
force-pushed
the
add_cr
branch
from
b2820b4
to
151f120
Compare
|
why is this useful? aren't those putlog lines limited anyway? |
what about Line 62 in 901c3a1 |
Merge done to trigger new CI run
michaelortmann
changed the title
michaelortmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Remove the limit of 1024 chars for input/output of add_cr() and escape_telnet()
Additional description (if needed):
Additionally refactor dccutil.c:add_cr() and dcc.c:escape_telnet() into a single misc.c:add_cr()
Test cases demonstrating functionality (if applicable):
Connecting to the bot via telnet was successful and output was the same as before.