Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to configure size & records of ingest batches. #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mosche
Copy link

@mosche mosche commented Sep 15, 2020

I've recently run into the ingest record limit (10k). Unfortunately there's no work around due to the repartitioning done here.
This PR adds two configuration options to better control ingest batches:

  • batchSize: (Optional) The size in bytes per ingest batch. Default value is 10 MB, maximum size is 10 MB.
  • batchRecords: (Optional) The number of records per ingest batch. Per default only batchSize is considered. Maximum number of records per batch is 10,000.

Both are optional and if not set, the behavior remains as is: ingest batches will be up to an estimated 10 MB large despite the number of records.

@mosche
Copy link
Author

mosche commented Sep 15, 2020

@samuel-pt @springml Would appreciate your 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant