Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix insetting of scene view #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jurvis
Copy link

@jurvis jurvis commented Dec 13, 2019

Checklist

Motivation and Context

When setting ShinyView to the frame of device, a strange inset is present on iPad:
Simulator Screen Shot - iPad Pro (12 9-inch) (3rd generation) - 2019-12-13 at 10 58 50

Ran my fix on the iPad simulator which did end up rendering fine + example app still works:
Simulator Screen Shot - iPad Pro (12 9-inch) (3rd generation) - 2019-12-13 at 11 17 28

Description

removed the setting of scene view's frame from it's initialiser and do it in ShinyView's layoutSubviews instead

@jurvis
Copy link
Author

jurvis commented Dec 13, 2019

sample project demonstrating the bug: https://we.tl/t-YDC6mJDQf2

@efremidze
Copy link
Owner

You are also removing the inset. The inset is necessary for the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants