Fix losing messages. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
client.sendfails during theputoperation, as it's asynchronous, it might commit offsets before getting the error, so messages might be lost.This is what happens when using a wrong SQS URL, it consumes a few messages and then it stops.
According to the docs, returning a
RetriableExceptionrather thanRuntimeExceptionforces Kafka Connect to retry the operation, which also ensures that messages are not committed.Tested manually and it doesn't lose messages.
This PR was opened to the original repo too, but not merged yet. Nordstrom#57