Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError when finishing a level while playing with a Tile World tileset causes all rending to stop #90

Open
normanr opened this issue Jun 20, 2022 · 0 comments

Comments

@normanr
Copy link

normanr commented Jun 20, 2022

When finishing a level _draw_visual_state1 is asked to draw a state of exited.

  • Tile World (static) tilesets don't have exited so (even though the code logs a warning) it proceeds to call draw_drawspec, which fails because it Cannot read properties of undefined (reading '__special__').
  • Tile World (animated) tilesets have exited, but it's an alias to normal, which itself is an alias to moving. The code in _draw_visual_state only resolves aliases once, so a string is passed to draw_drawspec, and it calls _draw_standard which fails with Cannot read properties of undefined (reading '0').

Footnotes

  1. https://github.com/eevee/lexys-labyrinth/blob/b4ebdf069d55817e7a983addcbda042b353b3bd0/js/tileset.js#L2457-L2470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant