Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error collision #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix error collision #61

wants to merge 1 commit into from

Commits on Jul 29, 2024

  1. Fix error collision 

    There are four types of errors:

- Unknown seed,
- CRC mismatch,
- Invalid types,
- Execution time < 10s.

All of these errors are handled by the 'total_errors' variable.
However, handling of the 'unknown seed' error differs from other types:
it sets 'total_errors' to -1, while other types of errors increment this variable.
This behavior leads to situations where one error overrides another.
For example, if you compile the program incorrectly and get an unknown
seed, and then run the program for less than 10 seconds, you will get
total_errors = 0 (because one error sets it to -1, while another
increments it to 0). See eembc#4.
As a result, you'll receive "Correct operation validated" when you
shouldn't.
    @HepoH3
    HepoH3 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4b7efe6 View commit details
    Browse the repository at this point in the history