refactoring embedded script

eebbesen · Oct 9, 2024 · 003a22d · 003a22d
1 parent 7c48db5
commit 003a22d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/public/js/script.js b/public/js/script.js
@@ -29,10 +29,6 @@ export function formatGeoInfo(loc) {
   return str;
 }
 
-export function showLocations(html) {
-  document.querySelector('#results').innerHTML = html;
-}
-
 export function locationError(err) {
   console.log('Error getting location', err);
   let message = `
@@ -47,15 +43,15 @@ export function locationError(err) {
   return `${message}</div>`;
 }
 
-export function populateResults(c) {
+export function populateResults() {
   navigator.geolocation.getCurrentPosition(
     function (location) {
       const xhr = new XMLHttpRequest();
       xhr.onload = function () {
         const json = JSON.parse(xhr.response);
         const html = formatResults(json);
 
-        return showLocations(html);
+        return document.querySelector('#results').innerHTML = html;
       };
       xhr.open(
         'GET',
@@ -68,7 +64,7 @@ export function populateResults(c) {
       xhr.send();
     },
     function (err) {
-      return showLocations(locationError(err));
+      return document.querySelector('#results').innerHTML = locationError(err);
     },
   );
 }

diff --git a/src/script.js b/src/script.js
@@ -29,10 +29,6 @@ export function formatGeoInfo(loc) {
   return str;
 }
 
-export function showLocations(html) {
-  document.querySelector('#results').innerHTML = html;
-}
-
 export function locationError(err) {
   console.log('Error getting location', err);
   let message = `
@@ -47,15 +43,15 @@ export function locationError(err) {
   return `${message}</div>`;
 }
 
-export function populateResults(c) {
+export function populateResults() {
   navigator.geolocation.getCurrentPosition(
     function (location) {
       const xhr = new XMLHttpRequest();
       xhr.onload = function () {
         const json = JSON.parse(xhr.response);
         const html = formatResults(json);
 
-        return showLocations(html);
+        return document.querySelector('#results').innerHTML = html;
       };
       xhr.open(
         'GET',
@@ -68,7 +64,7 @@ export function populateResults(c) {
       xhr.send();
     },
     function (err) {
-      return showLocations(locationError(err));
+      return document.querySelector('#results').innerHTML = locationError(err);
     },
   );
 }