Skip to content

feat: Updated Chat Trial Audit gating consistency #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

rijuma
Copy link
Contributor

@rijuma rijuma commented Feb 5, 2025

Description

Ticket: COSMO-612 🔒

There was some differences between the Xpert Chat Trial conditions for the trial on the frontend vs the backend.

Removed deprecated enabled and history endpoints that were integrated in the new summary endpoint. (Ticket: COSMO-600 🔒)

These changes would make the checks more consistent.

@rijuma rijuma force-pushed the rijuma/improve-audit-eligibility branch 15 times, most recently from c3bd256 to 985b7f2 Compare February 11, 2025 12:35
Copy link

github-actions bot commented Feb 11, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  learning_assistant
  api.py
  urls.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@rijuma rijuma force-pushed the rijuma/improve-audit-eligibility branch 6 times, most recently from 6a79bd1 to 7783683 Compare February 11, 2025 20:32
@rijuma rijuma marked this pull request as ready for review February 11, 2025 20:33
@rijuma rijuma force-pushed the rijuma/improve-audit-eligibility branch from 7783683 to 4ccd01b Compare February 13, 2025 14:23
Copy link
Member

@michaelroytman michaelroytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a little feedback.

Two more things.

  1. I don't think that chore is the appropriate commit type here. This is a feat, in my opinion, because it changes the functionality of the application. If you agree, could you update the commit message and PR title?
  2. Could you add COSMO-600 to your pull request description and drop a link to this PR on the ticket in Jira, please? It will help us track our work better.

Thanks!

@rijuma rijuma force-pushed the rijuma/improve-audit-eligibility branch from 4303cbd to 18316c2 Compare February 18, 2025 13:42
@rijuma rijuma force-pushed the rijuma/improve-audit-eligibility branch from 18316c2 to 6043269 Compare February 18, 2025 13:42
@rijuma rijuma changed the title chore: Updated Chat Trial Audit gating consistency feat: Updated Chat Trial Audit gating consistency Feb 18, 2025
@rijuma rijuma force-pushed the rijuma/improve-audit-eligibility branch from 6043269 to b47a796 Compare February 18, 2025 13:50
@rijuma
Copy link
Contributor Author

rijuma commented Feb 18, 2025

Looks good! I left a little feedback.

Two more things.

  1. I don't think that chore is the appropriate commit type here. This is a feat, in my opinion, because it changes the functionality of the application. If you agree, could you update the commit message and PR title?
  2. Could you add COSMO-600 to your pull request description and drop a link to this PR on the ticket in Jira, please? It will help us track our work better.

Thanks!

Thank you for your exhaustive review @michaelroytman. Let me know what you think on the updates.

Copy link
Member

@michaelroytman michaelroytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for incorporating my feedback.

I left one comment on the change I originally suggested to the >= end condition, but it's not blocking.


valid_dates = (
(start <= today if start else True)
and (end > today if end else True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you removed the end >= today. Do you plan to make the same change on the frontend?

(By the way, I do think this is very edge-casey, and on further reflection, isn't a big deal. So feel free to change it back if it makes your life easier.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rolled it back to match the frontend. To be honest, since both dates includes time it's just pointless to consider the exact moment that both dates are matching. I've rolled it back to be consistent with the frontend.
Giving the extreme edge case, I don't think it's worth the surgical analysis we are putting into.

@rijuma rijuma merged commit eb8c404 into main Feb 19, 2025
4 checks passed
@rijuma rijuma deleted the rijuma/improve-audit-eligibility branch February 19, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants