-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Updated Chat Trial Audit gating consistency #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c3bd256
to
985b7f2
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
6a79bd1
to
7783683
Compare
7783683
to
4ccd01b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a little feedback.
Two more things.
- I don't think that
chore
is the appropriate commit type here. This is afeat
, in my opinion, because it changes the functionality of the application. If you agree, could you update the commit message and PR title? - Could you add
COSMO-600
to your pull request description and drop a link to this PR on the ticket in Jira, please? It will help us track our work better.
Thanks!
4303cbd
to
18316c2
Compare
18316c2
to
6043269
Compare
6043269
to
b47a796
Compare
Thank you for your exhaustive review @michaelroytman. Let me know what you think on the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for incorporating my feedback.
I left one comment on the change I originally suggested to the >= end
condition, but it's not blocking.
learning_assistant/views.py
Outdated
|
||
valid_dates = ( | ||
(start <= today if start else True) | ||
and (end > today if end else True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you removed the end >= today
. Do you plan to make the same change on the frontend?
(By the way, I do think this is very edge-casey, and on further reflection, isn't a big deal. So feel free to change it back if it makes your life easier.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rolled it back to match the frontend. To be honest, since both dates includes time it's just pointless to consider the exact moment that both dates are matching. I've rolled it back to be consistent with the frontend.
Giving the extreme edge case, I don't think it's worth the surgical analysis we are putting into.
Description
Ticket: COSMO-612 🔒
There was some differences between the Xpert Chat Trial conditions for the trial on the frontend vs the backend.
Removed deprecated
enabled
andhistory
endpoints that were integrated in the new summary endpoint. (Ticket: COSMO-600 🔒)These changes would make the checks more consistent.