fix: Gates the chat history endpoint behind a waffle flag #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
rijuma
force-pushed
the
rijuma/gate-chat-history
branch
from
eb18d27 to
010052e
Compare
varshamenon4
approved these changes
Nov 22, 2024
| @@ -247,6 +247,10 @@ def get(self, request, course_run_id): | |||
| data={'detail': 'Learning assistant not enabled for course.'} | |||
| ) | |||
|
|
|||
| # If chat history is disabled, we return no messages as response. | |||
| if not chat_history_enabled(courserun_key): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only logic for the chat history behind the feature flag
learning_assistant.enable_chat_historyis the saving of the messages.If we want to disable the feature, the chats are no longer being saved but the existing ones will still be returned by the learning Assistant Message History endpoint.
This update makes sure that if the flag for the chat history is disabled, the endpoint would just return an empty list.