feat: Updated Disclaimer screen with trial option #73
Conversation
rijuma
force-pushed
the
rijuma/xpert-trial-welcome
branch
2 times, most recently
from
42a496b to
151fdff
Compare
|
I'll take a closer look at this tomorrow, but the message input should be closer to the bottom of the chat sidebar! It looks like its position moved (and this also differs from the Figma mocks) in the screenshots you provided. |
rijuma
force-pushed
the
rijuma/xpert-trial-welcome
branch
from
151fdff to
484ef9d
Compare
|
FYI I'm going to be rebasing my PR (#72) onto this one so our changes are synced. |
* feat: Added trial url and days to the chat intro * feat: Updated some logic for the useCourseUpgrade() hook
Updated! |
Co-authored-by: Alison Langston <[email protected]>
rijuma
force-pushed
the
rijuma/xpert-trial-welcome
branch
from
52f19b2 to
c61291b
Compare
rijuma
force-pushed
the
rijuma/xpert-trial-welcome
branch
from
b0582c3 to
4bd5522
Compare
src/components/Disclosure/index.jsx
Outdated
| const { upgradeable, upgradeUrl, auditTrialLengthDays } = useCourseUpgrade(); | ||
| const { track } = useTrackEvent(); | ||
|
|
||
| const handleClick = () => track('edx.ui.lms.learning_assistant.message'); |
There was a problem hiding this comment.
Just noticed this as I'm working through my rebase/refactor, but I don't think this is the correct event name. The message suffix would make more sense for segment events tracked for each message sent, but something like upgrade_click might be more suitable for this specific event.
There was a problem hiding this comment.
Thanks for noticing this. I've changed it for edx.ui.lms.learning_assistant.disclosure_upgrade_click. My thoughts on this is to be able to tell whether a student updated straight from the disclosure message or from the other instances (Upgrade through the banner or the paywall when the trial expired).
|
|
||
| const millisecondsInOneDay = 24 * 60 * 60 * 1000; // hours*minutes*seconds*milliseconds | ||
|
|
||
| export default function useCourseUpgrade() { |
There was a problem hiding this comment.
Could you add comments on the key utility of this hook?
There was a problem hiding this comment.
You're right. Thanks for the recommendation. I've added the JSDoc comments for both new hooks.
rijuma
force-pushed
the
rijuma/xpert-trial-welcome
branch
from
8f7500f to
ba7a021
Compare
rijuma
force-pushed
the
rijuma/xpert-trial-welcome
branch
from
ba7a021 to
0659a97
Compare
Ticket: COSMO-570🔒
Description
We are going to introduce a limited time free trial for audit users. This PR prepares the UI for that.
I've added the trial message to be shown by a prop, but it's currently disabled. This new UI element with the CTA will be tackled in ticket COSMO-602🔒 but I just took the opportunity to include it since it was just removing part of the mockup.
I took the opportunity to add some extra tweaks to the general UI to look closer to the expected figma design.
Screenshots
Without trial message
With trial message