Skip to content

Commit

Permalink
👷🏽‍♀️ Pipeline maintenance (#166)
Browse files Browse the repository at this point in the history
* Ensure hub tool is installed for release creation
* Remove travis pipeline definition file
* Use sonar.token property instead of sonar.login
eduherminio authored Dec 2, 2023
1 parent da24c0c commit bdabd9b
Showing 4 changed files with 9 additions and 18 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -74,7 +74,7 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
shell: powershell
run: |
.\.sonar\scanner\dotnet-sonarscanner begin /k:"eduherminio_FileParser" /o:"eduherminio-github" /d:sonar.login="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.coverageReportPaths="coveragereport/SonarQube.xml" /d:sonar.scanner.force-deprecated-java-version=true
.\.sonar\scanner\dotnet-sonarscanner begin /k:"eduherminio_FileParser" /o:"eduherminio-github" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.coverageReportPaths="coveragereport/SonarQube.xml" /d:sonar.scanner.force-deprecated-java-version=true
- name: '[Ubuntu] Set version to -ci-${{ github.run_number }}'
if: matrix.os == 'ubuntu-latest'
@@ -135,4 +135,4 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
shell: powershell
run: |
.\.sonar\scanner\dotnet-sonarscanner end /d:sonar.login="${{ secrets.SONAR_TOKEN }}"
.\.sonar\scanner\dotnet-sonarscanner end
6 changes: 6 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -38,6 +38,12 @@ jobs:
PROJECT_NAME: FileParser

steps:

- name: Install hub tool
if: github.event.inputs.should_create_github_release == 'true'
run: |
sudo apt-get update && sudo apt-get install -y hub
- uses: actions/checkout@v4

- name: Configure git user
14 changes: 0 additions & 14 deletions .travis.yml

This file was deleted.

3 changes: 1 addition & 2 deletions FileParserSolution.sln
Original file line number Diff line number Diff line change
@@ -9,15 +9,14 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FileParser.Test", "tests\Fi
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{D8E3B14F-7393-4CEF-9EDB-2E630190FACD}"
ProjectSection(SolutionItems) = preProject
.travis.yml = .travis.yml
azure-pipelines.yml = azure-pipelines.yml
.github\workflows\ci.yml = .github\workflows\ci.yml
.circleci\config.yml = .circleci\config.yml
Directory.Build.props = Directory.Build.props
.github\workflows\release.yml = .github\workflows\release.yml
EndProjectSection
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FileParser.Benchmark", "src\FileParser.Benchmark\FileParser.Benchmark.csproj", "{600D80DB-4DCB-47BE-9761-30C8CD584C32}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FileParser.Benchmark", "src\FileParser.Benchmark\FileParser.Benchmark.csproj", "{600D80DB-4DCB-47BE-9761-30C8CD584C32}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution

0 comments on commit bdabd9b

Please sign in to comment.