Avoid possibility of thread race conditions with concurrent generator…

…s on global list structures.
educates · Jul 14, 2022 · 8c12195 · 8c12195
1 parent e8f49ab
commit 8c12195
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/session-manager/handlers/kyverno_rules.py b/session-manager/handlers/kyverno_rules.py
@@ -19,9 +19,9 @@ def kyverno_environment_rules(workshop_spec, environment_name):
 
     rules = []
 
-    for clusterpolicy in kyverno_policies:
+    for clusterpolicy in list(kyverno_policies):
         policy_name = xget(clusterpolicy, "metadata.name")
-        policy_rules = xget(clusterpolicy, "spec.rules", [])
+        policy_rules = list(xget(clusterpolicy, "spec.rules", []))
 
         for index, rule in enumerate(policy_rules, start=1):
             rule = copy.deepcopy(rule)

diff --git a/session-manager/handlers/operator_config.py b/session-manager/handlers/operator_config.py
@@ -133,7 +133,7 @@ def image_reference(name):
     version = xget(config_values, "version", "latest")
     image = f"{IMAGE_REPOSITORY}/educates-{name}:{version}"
     image_versions = xget(config_values, "imageVersions", [])
-    for item in image_versions:
+    for item in list(image_versions):
         if item["name"] == name:
             image = item["image"]
             break

diff --git a/session-manager/handlers/workshopenvironment.py b/session-manager/handlers/workshopenvironment.py
@@ -348,7 +348,7 @@ def workshop_environment_create(name, body, meta, spec, status, patch, logger, *
         ipv4_blockcidrs = []
         ipv6_blockcidrs = []
 
-        for block in NETWORK_BLOCKCIDRS:
+        for block in list(NETWORK_BLOCKCIDRS):
             if ":" in block:
                 ipv6_blockcidrs.append(block)
             else:

diff --git a/session-manager/handlers/workshopsession.py b/session-manager/handlers/workshopsession.py
@@ -166,7 +166,7 @@ def _setup_session_namespace(
         ipv4_blockcidrs = []
         ipv6_blockcidrs = []
 
-        for block in NETWORK_BLOCKCIDRS:
+        for block in list(NETWORK_BLOCKCIDRS):
             if ":" in block:
                 ipv6_blockcidrs.append(block)
             else: