Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open response assesment detail (problem steps) UI #5

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

BryanttV
Copy link

@BryanttV BryanttV commented Feb 22, 2024

ref: openedx#263

Description

This PR allows us to see in detail each step of an open response, which means Training, Peer, Self, and Staff, and can also see feedback received and feedback given.

demo

Responses List

Before Now
image image

Assessments Feedback Received

image

Assessments Feedback Given

image

Here's what you see in the video explained:

  • There is an ORA open response type Staff Assessment Only.
  • The instructor opens the new experience of ORA that contains the submissions of that Open response.
  • The instructor can see the details and more information, such as email, full name, list of responses, and feedback in detail.

Why are we proposing these changes?

This improvement enables instructors to access detailed information for each Open Response, making it easier for them to review ORA responses and maintain better control over the feedback process.

Dependencies

Testing Instructions

Using Tutor:

  1. Clone this repository in your environment and checkout to this branch.
  2. Into the repo run nvm use && npm install
  3. Create a mount of this MFE with tutor mounts add frontend-app-course-authoring
  4. Run tutor dev start -d to create the new container of ORA Grading.
  5. From Studio create a unit with an open response type Staff Assessment Only.
  6. From LMS submit the response.
  7. Go to the Instructor Tab > Open Responses.
  8. In the unit click on View and grade responses. Here you can see the new fields added to the table (Email, Problem steps, and Action)
  9. Click in View details, and look at the new assessment tables.

@BryanttV BryanttV force-pushed the bav/feat-problem-steps-detail-ui branch from 8713a74 to 0080e16 Compare February 22, 2024 15:26
@BryanttV BryanttV force-pushed the bav/feat-problem-steps-detail-ui branch from 0080e16 to 980069b Compare February 22, 2024 15:43
@@ -18,7 +18,7 @@ const messages = defineMessages({
},
idAssessmentColumnTitle: {
id: 'ora-grading.ReviewProblemStepsContent.idAssessmentColumnTitle',
defaultMessage: 'ID Assessment',
defaultMessage: 'Assessment ID',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing this? The mockup in the Figma doesn't look like this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the API it is returned as assessment_id, I modified it for consistency. But it could be left as it looks in the mockup.

Comment on lines 26 to 31
let data;
if (feedbackListType === 'received') {
data = await api.getFeedbackFromList(submissionUUID);
} else {
data = await api.getFeedbackToList(submissionUUID);
}
Copy link

@johnvente johnvente Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: If we had more options this way I could add more promises

const feedbackListTypesResponses = {
 'received':  api.getFeedbackFromList(submissionUUID), 
 'given': api.getFeedbackToList(submissionUUID), 
};

const response = feedbackListTypes[feedbackListType] || Promise.resolve({ assessments: [] });

const data = await response;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Done

@johnvente
Copy link

Hi there @BryanttV! Thanks for doing this. I left a couple of minor comments. Probably this will need some tests I will be cheking out that later

@BryanttV BryanttV force-pushed the bav/feat-problem-steps-detail-ui branch 5 times, most recently from 343da29 to fb2727b Compare February 28, 2024 17:50
@BryanttV BryanttV force-pushed the bav/feat-problem-steps-detail-ui branch from 5659b56 to e76429c Compare May 10, 2024 15:51
@BryanttV BryanttV force-pushed the bav/feat-problem-steps-detail-ui branch from e76429c to aba4c7f Compare June 6, 2024 21:53
@BryanttV BryanttV force-pushed the bav/feat-problem-steps-detail-ui branch from aba4c7f to 1b9fa9d Compare June 6, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants