Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: redwood release support DS-1011 #212

Merged
merged 14 commits into from
Jun 26, 2024
Merged

perf: redwood release support DS-1011 #212

merged 14 commits into from
Jun 26, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Jun 21, 2024

Description

This PR adds support for the Open edX Redwood release.

These were the changes made:

  • Upgraded requirements based on the edx-platform Redwood release.
  • Updated GitHub workflows with new Python (3.10 and 3.11) and actions version.
  • Added Python 3.10 and 3.11 in the tox.ini file.
  • Updated the Integration Tests to use the Redwood release with Tutor.

Testing instructions

  1. Create an environment with Redwood release, you can use Tutor or TVM.
  2. Install the Django plugin eox-tenant using this PR branch, you can use the steps in Tutor documentation.
  3. Run the test cases. In this file, you can find more information about the plugin configuration.

Aditional information

  • The backend for users has been updated. In this module the UserSignupSource class is imported from edx-platform, however, the path is incorrect from the Palm release.

Warning

In the Palm and Quince version of Open edX it is necessary to use this last version that solves the error in the backend.

Related Issues

@Alec4r Alec4r requested review from Alec4r and Asespinel June 21, 2024 03:38
@BryanttV BryanttV requested review from a team and removed request for Alec4r and Asespinel June 21, 2024 15:37
@bra-i-am
Copy link
Contributor

bra-i-am commented Jun 24, 2024

Looks good to me! Thanks a lot for enhancing the document of test cases, it's pretty nice!

PD: I misclicked and sent the approval without the comment 🤦

Copy link
Contributor

@luisfelipec95 luisfelipec95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mariajgrimaldi
Copy link
Collaborator

@BryanttV: if this version is still compatible with quince, we don't need to backport it. Maybe we should update the compatibility notes for quince, but not much more.

Since this was already approved, let's do it in another PR.

@BryanttV BryanttV merged commit 22bc907 into master Jun 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants