Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create_or_update_tenant_config management command #182

Merged
merged 6 commits into from
Nov 7, 2023
Merged

feat: add create_or_update_tenant_config management command #182

merged 6 commits into from
Nov 7, 2023

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented May 16, 2023 •
edited
Loading

Description

Adds custom command to create or update tenant configuration via command line similar to create_or_update_site_configuration from openedx.

Testing instructions

Follow example usage added in readme file.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@navinkarkera navinkarkera changed the title Navin/tenant config command feat: add create_or_update_tenant_config management command May 16, 2023
@navinkarkera navinkarkera marked this pull request as ready for review May 16, 2023 05:50
@navinkarkera navinkarkera force-pushed the navin/tenantConfig-command branch 2 times, most recently from a27ef89 to 07b5029 Compare May 18, 2023 05:57
@MaferMazu
Copy link
Contributor

Thanks for this PR, @navinkarkera. We will talk about this with product and let you know of any updates.

cc @santiagosuarezedunext

kaustavb12
kaustavb12 approved these changes May 26, 2023
View reviewed changes
Copy link

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Tested in devstack as well as sandbox
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@santiagosuarezedunext
Copy link

Since it is a PR I am going to move it directly to prioritized and we will analyze it in subsequent sprints
@MaferMazu

@navinkarkera
Copy link
Contributor Author

@santiagosuarezedunext Rebased and fixed CI. Any updates on reviewing and merging this?

This was referenced Jul 3, 2023
Merged
Merged
@JuanDavidBuitrago
Copy link
Member

@santiagosuarezedunext Rebased and fixed CI. Any updates on reviewing and merging this?

@santiagosuarezedunext

@Asespinel
Copy link
Contributor

@santiagosuarezedunext could we check this PR in future sprints?

@kaustavb12
Copy link

@santiagosuarezedunext @Asespinel

Any updates on the review of this PR ?

@Asespinel
Copy link
Contributor

@santiagosuarezedunext do we have this feature mapped on our future sprints?

@santiagosuarezedunext
Copy link

santiagosuarezedunext commented Aug 18, 2023 •
edited
Loading

@navinkarkera Sorry for the delay, our team is working on some priorities, This PR is now in the prioritized section and as soon as we finish what we're at we'll start by reviewing PRs.
Thanks for the patience!

@felipemontoya
Copy link
Member

@Alec4r @DonatoBD this has been open for quite a while.
The technical component is good and to me this should be merged and released now. Do you have anything agaist me merging it?

@DonatoBD
Copy link

Hi @felipemontoya, i was checking it out and it looks like a great addition to eox-tenant. I totally agree with the merge 👍

@MaferMazu MaferMazu merged commit 19d0a20 into eduNEXT:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonatoBD DonatoBD DonatoBD approved these changes

@kaustavb12 kaustavb12 kaustavb12 approved these changes

@felipemontoya felipemontoya felipemontoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@navinkarkera @MaferMazu @santiagosuarezedunext @JuanDavidBuitrago @Asespinel @kaustavb12 @felipemontoya @DonatoBD