Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api test #53

Merged
merged 9 commits into from
Jun 25, 2024
Merged

feat: add api test #53

merged 9 commits into from
Jun 25, 2024

Conversation

luisfelipec95
Copy link
Contributor

@luisfelipec95 luisfelipec95 commented Jun 19, 2024

Description

This PR adds validation for the /eox-hooks/eox-info endpoint in the integration test

How to test

Checks:

  • Integration / integration-test (<17.0.0) (pull_request)

  • Integration / integration-test (<18.0.0) (pull_request)

Other information

SITE_ID = 2 is used to fix the error: django.contrib.sites.models.Site.DoesNotExist: Site match query does not exist.

When running an instance, SITE_ID is 2, so the setting was overridden so that during testing it also takes the SITE_ID = 2

https://edunext.atlassian.net/browse/DS-993

@mariajgrimaldi mariajgrimaldi mentioned this pull request Jun 20, 2024
4 tasks
@luisfelipec95 luisfelipec95 requested a review from a team June 21, 2024 19:45
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just a few comments.

eox_hooks/tests/tutor/integration_test_tutor.py Outdated Show resolved Hide resolved
eox_hooks/tests/tutor/integration_test_tutor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, LGTM!

@luisfelipec95 luisfelipec95 merged commit 914d303 into master Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants