Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Lilac backend #46

Merged
merged 1 commit into from
Nov 24, 2023
Merged

feat: add Lilac backend #46

merged 1 commit into from
Nov 24, 2023

Conversation

luisfelipec95
Copy link
Contributor

Description

This PR adds a Lilac backend which was removed in the migration to Palm.

Testing instructions

  1. Create an environment with Palm release, you can use Tutor or TVM
  2. Install the Django plugin eox-hooks, you can use steps in Tutor documentation.
  3. Run test cases

@luisfelipec95 luisfelipec95 requested review from a team and removed request for MaferMazu and dcoa November 23, 2023 13:47
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @luisfelipec95. It's perfect; I only suggest being more specific in the commit, for example, feat: add courses_l_v1 backend to maintain backward compatibility.

Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luisfelipec95 luisfelipec95 merged commit c196b2d into master Nov 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants