Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DS-706): add compatibility with Open edX palm release #43

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat(DS-706): add compatibility with Open edX palm release #43

merged 2 commits into from
Nov 20, 2023

Conversation

luisfelipec95
Copy link
Contributor

Description

This PR adds support for the Open edx Palm release.

Testing instructions

  1. Create an environment with Palm release, you can use Tutor or TVM
  2. Install the Django plugin eox-hooks, you can use steps in Tutor documentation.
  3. Run test cases

@luisfelipec95 luisfelipec95 requested review from a team and Alec4r November 17, 2023 15:10
bra-i-am
bra-i-am approved these changes Nov 17, 2023
View reviewed changes
Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! I didn't try the deprecated test cases, but the other ones trigger the signal of the webhook

Asespinel
Asespinel approved these changes Nov 17, 2023
View reviewed changes
Copy link

@Asespinel Asespinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@luisfelipec95 luisfelipec95 merged commit c8d4132 into master Nov 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bra-i-am bra-i-am bra-i-am approved these changes

@Asespinel Asespinel Asespinel approved these changes

@dcoa dcoa dcoa approved these changes

@Alec4r Alec4r Awaiting requested review from Alec4r

Assignees

@MaferMazu MaferMazu

@dcoa dcoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luisfelipec95 @dcoa @Asespinel @bra-i-am @MaferMazu