-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop support for Python 3.10 and Django 3.2 #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @magajh. This looks good.
My only comment is that we may want to modify the setup.py
to show these changes in the Pypi info.
Here: https://github.com/eduNEXT/eox-core/blob/master/setup.py#L64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magajh! Should we update changelog and bump version?
Hey @BryanttV. Since Python 3.10 and Django 3.2 are not used by any of the Open edX releases we support, I'm unsure if this change justifies making a new release (I believe Python 3.10 isn't even used by any Open edX release). What do you think? I was reviewing the documentation, but it's not entirely clear to me; maybe this could be a patch bump? |
I think we will need the bump version, and a major bump version. Because in our readme, we said that the latest version of eox-core works on maple, nutmeg, olive, and palm in the compatibilities notes. And with this change, for the dropping support of Django 3.2, that is the Django version used palm, we are dropping support for the releases before or equals palm. And based on Release Strategy doc, we should use a major if we change the compatibility and require users to adapt. In this case, someone using palm could no longer use the latest release of eox-core, and we are breaking compatibility for previous releases. I understand this is not a bump version change if we only think in Python and Django, but thinking about the release we support of Open edX, we are dropping support for maple, nutmeg, olive, and palm, which should be a major change. So, we probably want to update the readme to have an upper limit for those releases we are dropping support for and apply a major version. What do you think? |
@MaferMazu, I agree—I like this approach. Since we're dropping support for Django 3.2, we can officially say that previous releases are no longer supported and update the compatibility table accordingly. This doesn't necessarily mean that this version or future versions of the plugin will lose compatibility with Open edX releases from Maple - Palm. When the plugin is installed on the platform, versions of dependencies compatible with the required Python and Django versions will still be used, and we haven't really modified anything related to the user interface or the plugin's features in this PR. However, we can no longer guarantee it will work because we're not running tests for the necessary Django version. This got me thinking that we should better document our version support and update the compatibility table to reflect this. I'll open an issue to improve the doc and document these cases. Thanks! |
I was going to comment with that making a patch was the best thing to do but... not anymore, I agree with @MaferMazu's comment. |
eacefe5
to
2e053ef
Compare
Co-authored-by: Bryann Valderrama <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Thanks a lot for this ✨
Description:
This PR removes support for Django 3.2 and Python 3.10 from our plugin.
Rationale:
We have decided to drop support for these versions because none of the Open edX releases we support use Django 3.2 or Python 3.10. Therefore, maintaining compatibility with them is unnecessary.
For more context and information, please refer to AP-1490.
Changes:
tox.ini
file to eliminate specifications for Python 3.10 and Django 3.2.django32.txt
file.How to Test: