Skip to content

Commit

Permalink
Merge pull request openedx#34257 from Zeit-Labs/pythonize_pull_transl…
Browse files Browse the repository at this point in the history
…ations

chore: pull_translations: use less Makefile commands and move it to Python | FC-0012
  • Loading branch information
Feanil Patel authored Feb 20, 2024
2 parents 4fb1dba + 25b3794 commit 92cde34
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,9 @@ pull_plugin_translations: ## Pull translations from Transifex for edx_django_ut
pull_xblock_translations: ## pull xblock translations via atlas
rm -rf conf/plugins-locale/xblock.v1 # Clean up existing atlas translations
rm -rf lms/static/i18n/xblock.v1 cms/static/i18n/xblock.v1 # Clean up existing xblock compiled translations
mkdir -p conf/plugins-locale/xblock.v1/ lms/static/js/xblock.v1-i18n cms/static/js
python manage.py lms pull_xblock_translations --verbose $(ATLAS_OPTIONS)
python manage.py lms compile_xblock_translations
cp -r lms/static/js/xblock.v1-i18n cms/static/js
python manage.py cms compile_xblock_translations

pull_translations: ## pull translations from Transifex
git clean -fdX conf/locale
Expand Down
1 change: 1 addition & 0 deletions openedx/core/djangoapps/plugins/i18n_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def ensure_empty_directory(self, directory):
Ensure the pull directory is empty before running atlas pull.
"""
plugin_translations_root = directory
os.makedirs(plugin_translations_root, exist_ok=True)
if os.listdir(plugin_translations_root):
raise CommandError(f'"{plugin_translations_root}" should be empty before running atlas pull.')

Expand Down

0 comments on commit 92cde34

Please sign in to comment.