Skip to content

Commit

Permalink
feat: Remove tagging object rest api pagination (openedx#33311)
Browse files Browse the repository at this point in the history
  • Loading branch information
rpenido authored Sep 26, 2023
1 parent bbacdc8 commit 64adc5e
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,8 @@ def test_tag_course(self, user_attr, taxonomy_attr, tag_values, expected_status)

assert response.status_code == expected_status
if status.is_success(expected_status):
assert len(response.data.get("results")) == len(tag_values)
assert set(t["value"] for t in response.data["results"]) == set(tag_values)
assert len(response.data) == len(tag_values)
assert set(t["value"] for t in response.data) == set(tag_values)

@ddt.data(
# Can't add invalid tags to a object using a closed taxonomy
Expand Down Expand Up @@ -803,8 +803,8 @@ def test_tag_xblock(self, user_attr, taxonomy_attr, tag_values, expected_status)

assert response.status_code == expected_status
if status.is_success(expected_status):
assert len(response.data.get("results")) == len(tag_values)
assert set(t["value"] for t in response.data["results"]) == set(tag_values)
assert len(response.data) == len(tag_values)
assert set(t["value"] for t in response.data) == set(tag_values)

@ddt.data(
# Can't add invalid tags to a object using a closed taxonomy
Expand Down
2 changes: 1 addition & 1 deletion requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ click==8.1.6
openedx-events<8.6.0 # Open edX Events from Hooks Extension Framework (OEP-50)

# pinning this version to avoid updates while the library is being developed
openedx-learning==0.1.6
openedx-learning==0.1.7

# lti-consumer-xblock 9.6.2 contains a breaking change that makes
# existing custom parameter configurations unusable.
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,7 @@ openedx-filters==1.6.0
# via
# -r requirements/edx/kernel.in
# lti-consumer-xblock
openedx-learning==0.1.6
openedx-learning==0.1.7
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/kernel.in
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/development.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ openedx-filters==1.6.0
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
# lti-consumer-xblock
openedx-learning==0.1.6
openedx-learning==0.1.7
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/doc.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/doc.txt
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ openedx-filters==1.6.0
# via
# -r requirements/edx/base.txt
# lti-consumer-xblock
openedx-learning==0.1.6
openedx-learning==0.1.7
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/testing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ openedx-filters==1.6.0
# via
# -r requirements/edx/base.txt
# lti-consumer-xblock
openedx-learning==0.1.6
openedx-learning==0.1.7
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
Expand Down

0 comments on commit 64adc5e

Please sign in to comment.