feat: endpoint /api/ora_staff_grader/initialize upgraded
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandodev-net
changed the title
/api/ora_staff_grader/initialize upgraded
mariajgrimaldi
requested changes
Oct 16, 2023
| @@ -36,7 +37,7 @@ def _usernames_enabled(): | |||
| Checks if toggle for deanonymized usernames in report enabled. | |||
| """ | |||
|
|
|||
| return settings.FEATURES.get('ENABLE_ORA_USERNAMES_ON_DATA_EXPORT', False) | |||
| return settings.FEATURES.get("ENABLE_ORA_USERNAMES_ON_DATA_EXPORT", False) | |||
There was a problem hiding this comment.
We shouldn't add style changes to things we haven't modified, it generates unnecessary noise for the reviewers.
Comment on lines
+150
to
+191
| "assessment", | ||
| "assessment_part", | ||
| "assessment_feedback", | ||
| "assessment_feedback_option", | ||
| "submission", | ||
| "score", | ||
| ] | ||
|
|
||
| HEADERS = { | ||
| 'assessment': [ | ||
| 'id', 'submission_uuid', 'scored_at', | ||
| 'scorer_id', 'score_type', | ||
| 'points_possible', 'feedback', | ||
| ], | ||
| 'assessment_part': [ | ||
| 'assessment_id', 'points_earned', | ||
| 'criterion_name', 'criterion_label', | ||
| 'option_name', 'option_label', 'feedback' | ||
| "assessment": [ | ||
| "id", | ||
| "submission_uuid", | ||
| "scored_at", | ||
| "scorer_id", | ||
| "score_type", | ||
| "points_possible", | ||
| "feedback", | ||
| ], | ||
| 'assessment_feedback': [ | ||
| 'submission_uuid', 'feedback_text', 'options' | ||
| "assessment_part": [ | ||
| "assessment_id", | ||
| "points_earned", | ||
| "criterion_name", | ||
| "criterion_label", | ||
| "option_name", | ||
| "option_label", | ||
| "feedback", | ||
| ], | ||
| 'assessment_feedback_option': [ | ||
| 'id', 'text' | ||
| "assessment_feedback": ["submission_uuid", "feedback_text", "options"], | ||
| "assessment_feedback_option": ["id", "text"], | ||
| "submission": [ | ||
| "uuid", | ||
| "student_id", | ||
| "item_id", | ||
| "submitted_at", | ||
| "created_at", | ||
| "raw_answer", | ||
| ], | ||
| 'submission': [ | ||
| 'uuid', 'student_id', 'item_id', | ||
| 'submitted_at', 'created_at', 'raw_answer' | ||
| "score": [ | ||
| "submission_uuid", | ||
| "points_earned", | ||
| "points_possible", | ||
| "created_at", |
There was a problem hiding this comment.
Same comment here ^. Let's not add style changes to the lines we haven't changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: endpoint
/api/ora_staff_grader/initializeupgradedImplementation Details
Modifications were made in the following directories:
ORA2
edx-platform
This upgrade will consist of two PRs: one for ORA and the other for edx-platform. This is because the main serializer of the service resides in the platform. To test it, you'll need to fetch and set up the version of the platform with the serializer modification.
when i have authorization to contritute at Edunext's edx-platform fork, I'll send the platform's PR.