-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rest api docs (issue #4) #34
Conversation
* POST /api/logout - close session | ||
* GET /api/token - verifies whether auth token is still valid | ||
|
||
# Users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create separate methods for user administration?
For instance, give or remove permissions to manage teams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, lets add that when it was needed in client applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,40 @@ | |||
Short API doc. | |||
|
|||
# Authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we decided to develop a telegram bot, we need a way to authorize a telegram user. Does it make sense to create methods to grant and revoke access for a telegram user by token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any improvement makes sence :), but now this API is for MVP version only. We could extend it on demand, no need to design it carefully right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we have an issue #42 for this.
|
||
## Calendar Events Collection [/api/calendar/{id}/events] | ||
|
||
### Retreive calendar events [GET] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it would be useful to have a separate API method for search on the calendar (by date, creator, type, or description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, search or filters are useful. Lets add them on demand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created #49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created separate issues for defined improvements. Current state looks good for MVP.
PR for issue #4.
TODO