Fixed course being accessed from a different org site #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadali286
approved these changes
Oct 23, 2024
manan-memon
force-pushed
the
manan/EDLY-7116
branch
from
c976c38
to
77adf8e
Compare
Anas-hameed
requested changes
Nov 13, 2024
lms/djangoapps/course_wiki/views.py
Outdated
Comment on lines
41
to
43
| course_key = CourseKey.from_string(course_id) | ||
| course = get_course_by_id(course_key) | ||
| check_if_course_org_in_site_org_filters(course_key) |
There was a problem hiding this comment.
Why are we course objects when check_if_course_org_in_site_org_filters is also doing this?
There was a problem hiding this comment.
changed the function to use is_course_org_same_as_site_org from edly app, now the course object is only fetched in the view.
manan-memon
force-pushed
the
manan/EDLY-7116
branch
from
77adf8e
to
59ca33e
Compare
taimoor-ahmed-1
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of a course from different organization being accessed on LMS site of another one.
JIRA: https://edlyio.atlassian.net/browse/EDLY-7116