Added missing fields to Person and CourseRun Search API #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anas-hameed
reviewed
Sep 27, 2024
Comment on lines
+2354
to
+2357
| return [{ | ||
| 'id': area_of_expertise.id, | ||
| 'value': area_of_expertise.value, | ||
| } for area_of_expertise in sorted(result.object.areas_of_expertise.all(), key=attrgetter('id'))] |
There was a problem hiding this comment.
We can break this logic. Maybe into multiple lines for better understanding. One possible sol. can be. Better to order_by it, if it's a DB query.
areas = result.object.areas_of_expertise.all()
sorted_areas = sorted(areas, key=attrgetter('id'))
return [{'id': area.id, 'value': area.value} for area in sorted_areas]
Comment on lines
+429
to
+436
| given_name = indexes.CharField(model_attr='given_name') | ||
| family_name = indexes.CharField(model_attr='family_name', null=True) | ||
| slug = indexes.CharField(model_attr='slug') | ||
| email = indexes.CharField(model_attr='email', null=True) | ||
| major_works = indexes.CharField(model_attr='major_works', null=True) | ||
| published = indexes.BooleanField(model_attr='published') | ||
| phone_number = indexes.CharField(model_attr='phone_number', null=True) | ||
| website = indexes.CharField(model_attr='website', null=True) |
There was a problem hiding this comment.
Does this not require a migration file?
Comment on lines
+2362
to
+2364
| if social_networks: | ||
| return social_networks[0].url | ||
| return None |
There was a problem hiding this comment.
nit: it's better to use it the other way around. Deal with failure flow first in the code and return the happy at last. e.g
if not len(social_networks):
return None
Comment on lines
+2373
to
+2380
| def get_urls_detailed(self, result): | ||
| return [{ | ||
| 'id': network.id, | ||
| 'type': network.type, | ||
| 'title': network.title, | ||
| 'display_title': network.display_title, | ||
| 'url': network.url, | ||
| } for network in sorted(result.object.person_networks.all(), key=attrgetter('id'))] |
There was a problem hiding this comment.
Same, We can break the logic here.
| } for area_of_expertise in sorted(result.object.areas_of_expertise.all(), key=attrgetter('id'))] | ||
|
|
||
| def get_social_network_url(self, url_type, obj): | ||
| social_networks = [network for network in obj.person_networks.all() if network.type == url_type] |
There was a problem hiding this comment.
Is this querying database? Can't we filter in that case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following missing fields in the
course_runsandpeoplesearch apis.course_run:
people:
Testing details:
Curl the following api endpoints to verify the changes
course_run:
people: