Added currency field to course run search api #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anas-hameed
reviewed
Sep 2, 2024
|
|
||
| @property | ||
| def first_enrollable_paid_seat_price_currency(self): | ||
| # Sort in python to avoid an additional request to the database for order_by |
There was a problem hiding this comment.
nit: you can replace # comment with docstrings.
Anas-hameed
reviewed
Sep 2, 2024
| # Sort in python to avoid an additional request to the database for order_by | ||
| seats = sorted(self._enrollable_paid_seats(), key=self._upgrade_deadline_sort) | ||
| if not seats: | ||
| # Enrollable paid seats are not available for this CourseRun. |
There was a problem hiding this comment.
nit: We can remove the inline comment
muhammadali286
requested changes
Sep 2, 2024
manan-memon
force-pushed
the
manan/EDLY-6981
branch
from
21008e7
to
b0ecbfc
Compare
muhammadali286
approved these changes
Sep 2, 2024
|
Closing this PR as there is no need for this, required changes already merged in #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the currency code field for
first_enrollable_paid_seat_pricewhich is fetched from e-commerce for a paid verified course.JIRA: https://edlyio.atlassian.net/browse/EDLY-6981