Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6751] Check Mappings Before Activating the Catalog for ES #85

Merged
merged 12 commits into from
Jun 6, 2024

Conversation

muhammadali286
Copy link

@muhammadali286 muhammadali286 commented May 31, 2024

  1. Added --no-update-alias flag in update_index command. When its provided while running the command, update_index command will only create new indices but alias will be still pointing to old indices.
  2. Added a new management command set_alias, which will verify the existence of the mappings for the provided indices and set the Elastic Search alias to it.

Note: Data loader job will now use set_alias job to update the alias.

https://edlyio.atlassian.net/browse/EDLY-6751

@muhammadali286 muhammadali286 self-assigned this May 31, 2024
@muhammadali286 muhammadali286 marked this pull request as ready for review June 4, 2024 06:43
logger = logging.getLogger(__name__)


required_mappings = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this in a separate file away from code logic?

Copy link

@muhammadali124 muhammadali124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammadali286 muhammadali286 merged commit e16d41a into develop-koa Jun 6, 2024
1 check passed
@muhammadali286 muhammadali286 deleted the ali_sr/EDLY-6751-check-mappings-command branch June 6, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants