Fix for Too Many Open Files [6639] #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taimoor-ahmed-1
requested changes
Apr 15, 2024
| @@ -1123,6 +1138,8 @@ def _make_request(self, page): | |||
| params = {'page': page, 'page_size': self.PAGE_SIZE} | |||
| response = self.api_client.get(self.partner.lms_url + '/api/v1/course_average_rating/', params=params) | |||
| response.raise_for_status() | |||
| self.api_client.close() | |||
There was a problem hiding this comment.
we should close the connection first and then call raise_for_status()
| @@ -952,6 +965,8 @@ def _make_request(self, page): | |||
| settings.WORDPRESS_APP_AUTH_PASSWORD | |||
| ) | |||
| response = requests.get(self.api_url, auth=auth, params=params) | |||
| self.api_client.close() | |||
There was a problem hiding this comment.
since, we're not using the client here this will not help.
we can use a context manager over here:
with requests.get(self.api_url, auth=auth, params=params) as response:
response.raise_for_status()
return response.json()
muhammadali286
force-pushed
the
ali_sr/EDLY-6639-too-many-open-files
branch
from
b290a49
to
faec5c1
Compare
taimoor-ahmed-1
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.