Skip to content

Commit

Permalink
Reverted Add a additional language in the courserun API model. (#91)
Browse files Browse the repository at this point in the history
  • Loading branch information
muhammadali286 committed Sep 10, 2024
1 parent 30b73a3 commit a5fdfe5
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 11 deletions.
2 changes: 1 addition & 1 deletion course_discovery/apps/api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ class Meta(MinimalCourseRunSerializer.Meta):
'course_uuid', 'estimated_hours', 'invite_only', 'subjects',
'is_marketing_price_set', 'marketing_price_value', 'is_marketing_price_hidden', 'featured', 'card_image_url',
'average_rating', 'total_raters', 'yt_video_url', 'course_duration_override', 'course_difficulty',
'course_job_role', 'course_format', 'course_industry_certified_training', 'course_owner', 'course_language'
'course_job_role', 'course_format', 'course_industry_certified_training', 'course_owner',
)
read_only_fields = ('enrollment_count', 'recent_enrollment_count',)

Expand Down
1 change: 0 additions & 1 deletion course_discovery/apps/api/tests/test_serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,6 @@ def get_expected_data(cls, course_run, request):
'is_marketing_price_hidden': course_run.is_marketing_price_hidden,
'card_image_url': course_run.card_image_url,
'subjects': [],
'course_language': course_run.course_language
})
return expected

Expand Down
1 change: 0 additions & 1 deletion course_discovery/apps/course_metadata/data_loaders/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,6 @@ def _process_response(self, response):
course_run.course_job_role = body['course_job_role']
course_run.course_format = body['course_format']
course_run.course_industry_certified_training = body['course_industry_certified_training']
course_run.course_language = body['course_language']
course_run.course_owner = body['course_owner']
course_run.status = self._process_course_status(body['status'])

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Generated by Django 2.2.16 on 2024-09-10 16:05

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
('course_metadata', '0272_auto_20240830_1141'),
]

operations = [
migrations.RemoveField(
model_name='courserun',
name='course_language',
),
migrations.RemoveField(
model_name='historicalcourserun',
name='course_language',
),
]
7 changes: 0 additions & 7 deletions course_discovery/apps/course_metadata/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1346,13 +1346,6 @@ class CourseRun(DraftModelMixin, CachedMixin, TimeStampedModel):
max_length=255, null=True, blank=True, verbose_name=_("Course Owner")
)

course_language = models.CharField(
max_length=255,
null=True,
blank=True,
verbose_name=_("Language of the course run"),
)

STATUS_CHANGE_EXEMPT_FIELDS = [
'start',
'end',
Expand Down
1 change: 0 additions & 1 deletion course_discovery/apps/course_metadata/search_indexes.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ class CourseRunIndex(BaseCourseIndex, indexes.Indexable):
course_job_role = indexes.CharField(model_attr='course_job_role', null=True)
course_format = indexes.CharField(model_attr='course_format', null=True)
course_industry_certified_training = indexes.CharField(model_attr='course_industry_certified_training', null=True)
course_language = indexes.CharField(model_attr='course_language', null=True)

course_owner = indexes.CharField(model_attr='course_owner', null=True)

Expand Down

0 comments on commit a5fdfe5

Please sign in to comment.