Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutor indigo tutorial #7

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Tutor indigo tutorial #7

merged 10 commits into from
Jul 15, 2024

Conversation

hinakhadim
Copy link
Collaborator

@hinakhadim hinakhadim commented Apr 17, 2024

List of Customizations that can be made to Openedx using Tutor Indigo

@hinakhadim hinakhadim requested a review from regisb April 17, 2024 07:22
@hinakhadim hinakhadim self-assigned this Apr 17, 2024
Copy link
Collaborator

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed about half of the tutorial document, but I think you'll get the idea. Basically, we need to take users by the hand and describe step-by-step what they should be doing to customize the theme. This means writing more words and including more screenshots. It's a good start, though!

contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
@regisb
Copy link
Collaborator

regisb commented May 27, 2024

At first sight this is looking like a great improvement :) Is this PR ready for another round of review?

@hinakhadim
Copy link
Collaborator Author

Yes @regisb, this PR is ready for another round of review.

Copy link
Collaborator

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, a great improvement! I still have many comments though, but this is going in the right direction, and I think we're almost there.

contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
contents/tutorindigo.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! There are a few typos here and there, but they can be fixed later. Sorry for the late review!

@regisb regisb merged commit d1d6210 into main Jul 15, 2024
1 check passed
@regisb regisb deleted the hina/tutor-indigo-tutorial branch July 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants