Solution to Memory leaks by interning external strings #24 per @sletner #234
Conversation
|
This addresses this issue: #24 |
headers.lisp
Outdated
|
|
||
| (in-package :chunga) | ||
|
|
||
| (defvar *intern-unsafely*) |
There was a problem hiding this comment.
Initialize this with nil to simplify the check in as-keyword.
headers.lisp
Outdated
|
|
||
| (defun as-keyword (string &key (destructivep t)) | ||
| "Checks if the string STRING is found as a keyword and if it is, returns the keyword, otherwise it returns a string. Note that this is obviously not congruent to the name of the function, it is meant to be an override to the default behavior to avoid memory leaks in Hunchentoot" | ||
| (or (gethash string +string-to-keyword-hash+) |
There was a problem hiding this comment.
I would not go through +string-to-keyword-hash+ and instead invoke find-symbol directly.
So should I make this changes in chunga instead and open a PR there? |
Yes please! |
Ok, so I made a PR there, will make changes here to account for that as well |
|
Ok, made the PR over there, please take a look at the code since I am implementing it differently than here since it's all internal to chunga and there's no need for the |
|
The |
|
Thank you as well for the guidance and being so responsive! |
No description provided.