Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: stop to :use packages #212

Closed
wants to merge 2 commits into from

Conversation

kilianmh
Copy link

  • stop to use transitive dependencies
  • import-from utilized symbols instead

- stop to use transitive dependencies
- import-from utilized symbols instead
@hanshuebner
Copy link
Member

Rather than importing the symbols, it would be preferable to qualify their usage. I would not merge this PR as it does not add any value but makes future changes harder.

@kilianmh kilianmh changed the title Chore: import symbols in defpackage Chore: stop to :use packages Mar 19, 2023
@kilianmh
Copy link
Author

The main importance is to not :use other packages.

it would be preferable to qualify their usage

Now the symbols from external packages are qualified instead of being imported in the defpackage. @hanshuebner

On Linux with SBCL-2.3.2 and Allegro-10.1 loading and testing works fine. Especially on Lispworks it should be tested whether it works. (due to when-let from alexandria/lw)

@hanshuebner
Copy link
Member

The main importance is to not :use other packages.

I fail to see the importance at this point, but now the change looks more maintainable than the previous explicit imports.

@stassats
Copy link
Member

Seems like a non-issue. We'll deal with any potential future conflicts when they arise.

@stassats stassats closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants