Fix symbol internalization in KEYWORD package #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you get the symbol names in the |
|
The symbol names in the test package |
Reverting test package :IMPORT-FROM clause package name to KEYWORD, which should improve readability without unnecessary expansion of *PACKAGE*.
|
Reverting test package |
fjl
approved these changes
Feb 25, 2022
- STRING as argument for INTERN, FIND-PACKAGE and FIND-SYMBOL -> Avoid internalization of RUN-ALL-TESTS, FLEXI-STREAMS-TEST, STREAM-FILE-POSITION in KEYWORD package
kilianmh
changed the title
Summary:Fix symbol internalization in
-> Reduction of |
avodonosov
reviewed
Sep 9, 2023
| @@ -29,62 +29,62 @@ | |||
|
|
|||
| (in-package :cl-user) | |||
|
|
|||
| (unless (find-symbol (symbol-name :stream-file-position) :trivial-gray-streams) | |||
| (unless (find-symbol "STREAM-FILE-POSITION" :trivial-gray-streams) | |||
There was a problem hiding this comment.
This will break Allegro CL modern mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
keywordsindefpackage:exportand:shadowclauses with uninterned symbols. This avoids interning them in*package*, which should simplify autocompletion and may improve garbage collection.