HOTFIX: Explicitly list subpackages #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr0grog
force-pushed
the
528-subpackages-are-not-quite-exactly-externally-visible
branch
from
e06c8b3 to
5a9e006
Compare
When the list of packages only included 'web_monitoring', you could import our new subpackages (e.g. `web_monitoring.diff`) from installations that were created via `setup.py develop`, but not `setup.py install` or when installed via pip. Not good!
Mr0grog
changed the title
Mr0grog
deleted the
528-subpackages-are-not-quite-exactly-externally-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #528, we added subpackages. However, they can't always be imported. When the list of packages only included 'web_monitoring', you could import our new subpackages (e.g.
web_monitoring.diff) from installations that were created viasetup.py develop, but notsetup.py installor when installed via pip. Not good!This explicitly lists the new packages. An alternative would be to add
__init__.pyfiles to all of them and, insetup.py, use:I’m going ahead and merging as-is so other projects that depend on this are unblocked, but will change to the above alternative if we think that’s better in the long run, @danielballan.