Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block the build for translation errors #19

Merged
merged 13 commits into from
Feb 21, 2025

Conversation

Mr0grog
Copy link
Member

@Mr0grog Mr0grog commented Feb 21, 2025

This allows the translations lint/test step to fail without failing the whole job and thus blocking the build. It logs some summary info for the workflow so it's possible to keep an eye on the status of translation issues.

@Mr0grog Mr0grog force-pushed the text-edits-translation-fun branch from ad35cee to 08fa8ea Compare February 21, 2025 21:47
Copy link

👋 FYI, your PR has been automatically updated with changes to
client/src/intl/en.json, which contains all the translatable text
from the application (probably because you made changes to
the text of a component without updating this file).

Copy link

👋 FYI, your PR has been automatically updated with changes to client/src/intl/en.json, which contains all the translatable text from the application (probably because you made changes to the text of a component without updating this file).

@Mr0grog Mr0grog merged commit f3c4eee into text-edits Feb 21, 2025
@Mr0grog Mr0grog deleted the text-edits-translation-fun branch February 21, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant