Skip to content

Commit

Permalink
Allow (but still check) bad translations in CI
Browse files Browse the repository at this point in the history
This allows the translations lint/test step to fail without failing the whole job and thus blocking the build. It logs some summary info for the workflow so it's possible to keep an eye on the status of translation issues.
  • Loading branch information
Mr0grog committed Feb 21, 2025
1 parent 7a6ed8f commit 1936df8
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion .github/workflows/build-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,25 @@ jobs:
run: npm ci

- name: Spanish translation test
run: npm run test:intl-translations
# TODO: Make this error fatal when we have a strategy for translations!
#
# Right now, we are trying to quickly iterate on this community
# deployment of CEJST and don't have a clear process or strategy around
# how to handle translations. We're keeping this check in so we have an
# eye on what is or isn't translated, but missing or deprecated
# non-English strings should not stop the build and prevent us from
# merging or deploying changes.
continue-on-error: true
run: |
npm run test:intl-translations
if [ "${?}" -eq 0 ]; then
echo "✅ Translations: In good shape." >> $GITHUB_STEP_SUMMARY
else
echo "⚠️ Translations: English and Spanish are mismatched." >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "See *tranlsations* job logs for details." >> $GITHUB_STEP_SUMMARY
fi
deploy:
if: github.ref == 'refs/heads/main'
Expand Down

0 comments on commit 1936df8

Please sign in to comment.