Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts: add EDG_COORDINATOR_PROMETHEUS_ADDR to helm #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

charts: add EDG_COORDINATOR_PROMETHEUS_ADDR to helm #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/templates/coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ spec:
value: "{{ .Values.coordinator.clientServerHost }}:{{ .Values.coordinator.clientServerPort }}"
- name: EDG_COORDINATOR_DNS_NAMES
value: "{{ .Values.coordinator.hostname }},coordinator-mesh-api,coordinator-client-api,coordinator-mesh-api.{{ .Release.Namespace }},coordinator-client-api.{{ .Release.Namespace }},coordinator-mesh-api.{{ .Release.Namespace }}.svc.cluster.local,coordinator-client-api.{{ .Release.Namespace }}.svc.cluster.local"
- name: EDG_COORDINATOR_PROMETHEUS_ADDR
value: "{{ .Values.coordinator.prometheusHost }}:{{ .Values.coordinator.prometheusPort }}"
- name: EDG_COORDINATOR_SEAL_DIR
value: "{{ .Values.coordinator.sealDir }}"
- name: OE_SIMULATION
Expand Down Expand Up @@ -81,6 +83,8 @@ spec:
name: http
- containerPort: {{ .Values.coordinator.meshServerPort }}
name: grcp
- containerPort: {{ .Values.coordinator.prometheusPort }}
name: prometheus
Comment on lines +86 to +87
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that familiar with Promtheus, should this port be exposed over a Kubernetes service, or does prometheus collect from the Pod directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay.

After an internal discussion (started by your question) with a coworker we agreed on implementing it with an exposed Kubernetes service. Would you be interested in a PR like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can just update this PR please

resources:
{{- toYaml .Values.coordinator.resources | nindent 12 }}
volumeMounts:
Expand Down
3 changes: 3 additions & 0 deletions charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ coordinator:
# clientServerPort needs to be configured to the same port as in your client tool stack
clientServerHost: "0.0.0.0"
clientServerPort: 4433
# Prometheus exporter address
prometheusHost: "0.0.0.0"
prometheusPort: 9944
# hosName needs to match the host you expect the coordinator to run on
hostname: "localhost"
# SEAL_DIR needs to be set according to persistent storage
Expand Down