Retry calls to execute as well as to query
#577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the distant past, execute was quite different than query (execute couldn't take arguments and query could not include multiple commands), so it maybe made sense to have different retry behaviors. Now, execute and query are basically identical except for whether data is returned, and so I don't think there is any reason why they shouldn't both do retries. (I modeled the implementation after how I did this in the edgedb test suite's hacked up client: edgedb/edgedb#8249)
msullivan
force-pushed
the
retry-execute
branch
from
34a6fda to
ec92779
Compare
msullivan
force-pushed
the
retry-execute
branch
from
3214061 to
306804b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the distant past, execute was quite different than query (execute
couldn't take arguments and query could not include multiple
commands), so it maybe made sense to have different retry behaviors.
Now, execute and query are basically identical except for whether data
is returned, and so I don't think there is any reason why they
shouldn't both do retries.
(I modeled the implementation after how I did this in the edgedb test
suite's hacked up client: edgedb/edgedb#8249)