API fix: with_query_tag()/without_query_tag() #555
Conversation
| def with_query_tag(self, tag: str): | ||
| for prefix in ["edgedb/", "gel/"]: | ||
| if tag.startswith(prefix): | ||
| raise errors.InvalidArgumentError(f"reserved tag: {prefix}*") |
There was a problem hiding this comment.
Maybe just a warning? The server should ideally just silently ignore them
There was a problem hiding this comment.
I thought the same, but we will send e.g. gel/repl tags from the CLI or gel/ui from the UI/JS client, while the server has no knowledge about the peer identity; the server could also receive myapp/financial-queries equally, so it just records the tags as received without ignoring. Unless you meant to reserve gel/* for only server-internal queries like in some table GC tasks (instead of queries over the binary protocol), adding an error in client bindings is the last chance we can enforce exclusiveness on this tag namespace.
| if len(tag) > 128: | ||
| raise errors.InvalidArgumentError( | ||
| "tag too long (> 128 characters)" | ||
| ) |
There was a problem hiding this comment.
Do we check this server-side also?
No description provided.