Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codegen for pgsparse. #480

Closed
wants to merge 1 commit into from
Closed

Add codegen for pgsparse. #480

wants to merge 1 commit into from

Conversation

vpetrovykh
Copy link
Member

No description provided.

@vpetrovykh
Copy link
Member Author

I'm a little confused by the test skipping policy w.r.t. codegen. In the rest of the test suite we skip pgvector and pgsparse tests if the extensions are not detected, but codegen tests simply assume presence of pgvector (and pgsparse now). Is this something that needs to be updated and made skippable as well?

@vpetrovykh
Copy link
Member Author

We'll hold off on adding pgsparse, so I'm closing this (and reverting the other pgsparse commit).

@vpetrovykh vpetrovykh closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan Awaiting requested review from msullivan

@fantix fantix Awaiting requested review from fantix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vpetrovykh