-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration flow #100
Merged
Merged
Add migration flow #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Making Person abstract complicates things due to existing data)
with PC first instead of Person followed by change to abstract
slicing, extra quiz question, blank City insert
schema changes + more explanation
rv now unused function
change needless backlink query to regular one
Add sequence explanation and nice Event output
…dd-migration-flow
This was referenced Jun 2, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second major change to Easy EdgeDB since the PR a month ago that incorporated changes from Devon's massive onboarding feedback, syntax capitalization and various random other things: #96
That first PR was already long enough so intentionally avoided anything that would have cascading effects like a change in one chapter that changes the schema in the next and then the next.
The PR this time adds migration flow, namely all the necessary changes for a reader to use Easy EdgeDB with the migration tools instead of the manual commands before. Back when I first made Easy EdgeDB the migration tools were rougher and I had a Surface Go (!) so even pasting a migration command led to screens and screens of text and if something didn't match...so a lot of the book had some guesswork in what output would show up at any time.
There are also a number of changes where EdgeDB itself has improved since alpha, like enums and dates being able to be made before the unix epoch (important for this book which is set in the 19th century).
There is a lot of outright rewriting sections too (too many to mention here but check the commits) where the original felt weird, unnecessary or just wrong. And those had their own cascading effects down the chain.
Chinese: I attempted to keep it up to date with the English version but very soon saw just how much there was to change to add the migration flow so mostly gave up. Where possible though I harmonized them with the English version.
To keep the PR relatively small(!) I purposely avoided adding new content on some of the neat features (such as Globals), though some like date_duration snuck in pretty easily. And I couldn't resist the temptation to mention the splat operator in the section on the introspect keyword because the output with the double splat is so fantastic and shows just how much there is to see when you use that keyword. But the remainder will be for later.
After this PR is done there are three (four?) major changes planned.