fix(contract preaudit updates): make changes, fixes, upgrade as requested by contracts team #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minimized re-entrancy risks.
…ed check to prevent griefing
Closed
tmigone
reviewed
Feb 2, 2023
contract/contracts/Subscriptions.sol
Outdated
| int256 len = Prelude.max( | ||
| 0, | ||
| int64(sub.end) - Prelude.max(int64(currentBlock), int64(sub.start)) | ||
| function unlocked(Subscription memory sub) private view returns (uint128) { |
There was a problem hiding this comment.
Same as locked I'd change visibility to public (this one IS being used by the contract however).
There was a problem hiding this comment.
Same as above if we make it public we can consider changing the input parameters
Theodus
reviewed
Feb 6, 2023
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Co-authored-by: Theo Butler <[email protected]>
Co-authored-by: Theo Butler <[email protected]>
contracts: add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the
Subscriptions.solcontract based offFindingshere