Add verblib-based reverb node for Dynamic Reverb #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashodanger
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a more robust reverb than the faux delay-based method we were using previously. Not only can the parameters be more finely tuned, but it is easier to make "stronger" reverb without hitting feedback loops and other distortions that the delay nodes was causing at higher settings.
I've also switched the simple on/off toggle in the Sound Options menu to be None/Headphones/Speakers, with "Headphones" being a more subtle setting (especially indoor reverb in relation to room size) versus "Speakers", which is a stronger setting that carries across easier over a sound bar/external speakers/etc