Skip to content

Commit

Permalink
fix parameter issue 76 (#77)
Browse files Browse the repository at this point in the history
  • Loading branch information
tomamplius authored Nov 11, 2023
1 parent cae95d8 commit 526335a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions inc/toolbox.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ class PluginSinglesignonToolbox {
* @param array $query
* @return string
*/
public static function getCallbackUrl($id, $query = []) {
public static function getCallbackUrl($row, $query = []) {
global $CFG_GLPI;

$url = $CFG_GLPI['root_doc'] . '/plugins/singlesignon/front/callback.php';

$url .= "/provider/".$id;
$url .= "/provider/".$row['id'];

if (!empty($query)) {
$_SESSION['redirect'] = $query['redirect'];
Expand Down

1 comment on commit 526335a

@Hallikas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that my test environment callbackurl is missing provider id. It seems that this function is called from provider.class and preference.class, both are NOT using array as parameter, but single ID. This code will break callbackurl for SSO.

Please sign in to comment.