Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds various features and new behavior #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ToxiClay
Copy link

@ToxiClay ToxiClay commented Mar 30, 2023

Changes introduced in this rollup include:

  • Discriminating on Python major version in load_manifest

    • The "universal newline" flag has been assumed by default in all versions of Python 3, was deprecated in 3.3, and no longer functions in 3.11. This code includes a branch on detected Python major version to perform the correct open() command.
  • Adds a -skippatches flag to download and verify commands (Thanks to Xeniac-at)

    • There are a lot of patches available, and people may or may not want to download them all for space concerns. This feature allows the user to skip them. Crucially, the current implementation leaves the patch information in the local manifest, allowing users to download patches on an as-desired basis. This behavior is also added to the verify command, reducing the number of "missing file" entries.
  • Updates functionality for the verify command

    • By default, this script counts up the number of items that fail to verify, but don't list them. That isn't as helpful as it could be, so a new behavior additionally collects the directory path of the failed item(s) and lists them at the end of the operation.
  • Various grammatical fixes

Changes introduced in this rollup include:

* Discriminating on Python major version in load_manifest
 * The "universal newline" flag has been assumed by default in all versions of Python 3, was deprecated in 3.3, and no longer functions in 3.11. This code includes a branch on detected Python major version to perform the correct open() command.

* Adds a -skippatches flag to download and verify commands (Thanks to Xeniac-at)
 * There are a lot of patches available, and people may or may not want to download them all for space concerns. This feature allows the user to skip them. Crucially, the current implementation leaves the patch information in the local manifest, allowing users to download patches on an as-desired basis. This behavior is also added to the verify command, reducing the number of "missing file" entries.

* Updates functionality for the verify command
 * By default, this script counts up the number of items that fail to verify, but don't list them. That isn't as helpful as it could be, so a new behavior additionally collects the directory path of the failed item(s) and lists them at the end of the operation.

* Various grammatical fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant