Windows: update quantlib #181
Conversation
.github/workflows/windows.yaml
Outdated
| config: | ||
| - {os: windows-latest, r: 'devel'} | ||
| - {os: windows-latest, r: 'release'} | ||
| - {os: windows-latest, r: 'oldrel'} |
There was a problem hiding this comment.
I am not sure how much I want to bother with Windows (given that I already get it, with a slight delay, from r-universe). I feel I almost certainly do not want three versions.
But I can deal with that in a follow-up commit.
There was a problem hiding this comment.
Way slower than macOS + Linux too :-/
There was a problem hiding this comment.
I set it to r-release. May dial it down to pull_requests. Thanks though.
|
|
||
| RWINLIB=../windows/quantlib-1.29 | ||
| RWINLIB=../windows/quantlib |
| } else { | ||
| "https://github.com/rwinlib/quantlib/archive/v1.29.tar.gz" | ||
| } | ||
| download.file(url, basename(url), quiet = TRUE) |
There was a problem hiding this comment.
Thanks for providing 1.32. The new version (as of this week ...) is 1.33. RQuantLib builds without changes. If you have spare cycles to roll to 1.33 ...
There was a problem hiding this comment.
Sorry not right now, it was already a pain to build this one.
There was a problem hiding this comment.
I completely understand. Let's wait for the next (I think: bi-monthly) release or wait til things break. Being a release or two or three behind is far from deadly.
Really appreciate the help with the libraries on Windows.
|
Merged, and updated ChangeLog and NEWS. This release cycle is all you so far on macOS and Windows !! |
|
Maybe try to push this to CRAN. I think they are working on windows-arm64 right now. |
|
I have no preference when you submit and whether just this change or not, feel free to do it the standard way when you feel it is the right time. As you know, the libraries should not be downloaded as pre-compiled, but e.g. for Windows be part of Rtools/MXE. So ideally a configuration to build QuantLib would be added to MXE, then a bugzilla request to add it also to Rtools would be issued (part of R bugzilla). |
Add support for arm64 windows.
Also fixes #180