Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging latest #3

Open
wants to merge 344 commits into
base: docs
Choose a base branch
from
Open

Merging latest #3

wants to merge 344 commits into from

Conversation

edcdavid
Copy link
Owner

No description provided.

sebrandon1 and others added 30 commits October 19, 2021 08:58
@sebrandon1
Fix URL for ping test (#400)
a291525
@greyerof @jc-rh
CRD status handler using generic json template. (#391)
9f291be 
Co-authored-by: Jun Chen <[email protected]>
@edcdavid @jc-rh @hamadise
Get Release version from Git tag (#379)
ce4547a 
* Get Release version from Git tag

* Adding support for building all currently released images (tag based)

Co-authored-by: Jun Chen <[email protected]>
Co-authored-by: Salaheddine Hamadi <[email protected]>
@greyerof
New TC: CRDs status subresource availability (#372)
ebe0298 
This will test the partner repo's CRD example in github ci actions.
@edcdavid
removing no-effect incorect code to get rid of warnings (#403)
a435ca2
@sebrandon1 @jc-rh
Upgrade to Go 1.17.2 (#402)
8d1afa9 
* Upgrade to Go 1.17.2

* Add in adjustments to workflows from #395

Co-authored-by: Jun Chen <[email protected]>
@edcdavid
Adding lint to list of tools installed by make (#404)
8d11ed0
@edcdavid
Tainted kernel log improvement (#401)
d0be7e0 
* Tainted kernel log improvement
@greyerof
Reel.go trace changed to debug level. (#406)
8d55a81
@edcdavid
Run nodeport test once per namspace (#409)
fa4fa3c
@shimritproj @jc-rh
Integrate best practice reference into test catalog (#398)
2faeb92 
* Integrate best practice reference into test catalog

* Update

* Updated for every test the best practice reference.

* Resolved comment of Gonzalo

* resolved comments of Jun and Brandon

* Resolved comment of Jun

* Update resolved comment of Jun

* Update resolved comment of Jun

Co-authored-by: Shimrit peretz <[email protected]>
Co-authored-by: Jun Chen <[email protected]>
@hamadise
Replacing adhoc oc debug commands with precreated shell sessions to t…
03b5d5c 
…he debug pods managed by a daemon set (#395)

* open debug session with all nodes

kill pods instead of exit command

remove dependency to common from packages

fix linter

fix mocks and github workflow

* address PR comments
use daemon set
revert changes to github workflow
add chroot when required

* fix lint

* fix lint

* fix minikube issue

* fix Jun's comments

* run go mod tidy

* specify mockgen version to fix github action

* stop looking for debug pods in minikube

* Update go.sum

* Revert "specify mockgen version to fix github action"

This reverts commit 4744426.

* Fix make install-tools

* Revert "Revert "specify mockgen version to fix github action""

This reverts commit 3468629.

* use new label for debug pods

* add node selector to pod debug

* add daemonset handler to check the ds availability
add common suite for common setup and teardown

* update label to match partner repo

* update label

* add label to node
@jc-rh
Increase time out for deploying debug pods (#411)
fac1228
@edcdavid
Fix for "latest" image tag not created (#412)
9bacf5a
@edcdavid @sebrandon1 @jc-rh
Support for more accurate logs in claims and adaptation to Ginkgo V2.…
835e2c0 
…0 beta (#397)

* Support for more accurate logs in claims and adaptation to Ginkgo V2.0 beta

* Update pkg/tnf/handlers/generic/assertion/assertion.go

Co-authored-by: Brandon Palm <[email protected]>

* Update pkg/tnf/identifier/identifier.go

Co-authored-by: Brandon Palm <[email protected]>

* PR review

* PR review

* lint

* PR review

* PR Review Salah

* bumping test-network-function-claim to 1.0.5

* PR review Salah

* rest of merge

Co-authored-by: Brandon Palm <[email protected]>
Co-authored-by: Jun Chen <[email protected]>
@hamadise
make sure node has debug pod before testing tainted kernel (#414)
d2818cb
@greyerof
Fix observability TS panic in CRD TC. (#421)
ffbb611
@greyerof
Hugepages TC fix (#410)
a680688 
The hugepages TC implementation had two main problems:
- The /proc/meminfo file shows only the total hugepages for the default
  size, so in case hugepages count of a different size were configured
  in the machineconfig, that file won't reflect that count, so it
  caused the TC to fail.
- When MC has hugepages config per numa, this config is set in
  systemd.units, not in the kernelArguments.

With this change, the actual node hugepages values are retrieved by reading
these node files with "oc debug":
  /sys/devices/system/node/node<id>/hugepages/hugepages-<size>-kB/nr_hugepages
  E.g: /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages

In case machineconfig has valid hugepages config in the systemd.units (one
unit per numa and size), this info will be compared against node values.
Otherwise, kernelArguments will be parsed and compared against the total
count of hugepages of that size found in the node. This is because,
usually, when no hugepages per numa were explicitly set in the MC, the
value is balanced between all the numas in the system. In other words,
if system has 2 numas and kernelArguments show 256 hugepages of 2M size,
each numa will have 128 hugepages.
@edcdavid
Enabling intrusive tests in Github workflow (#423)
3a446be
@edcdavid
Fix for Ginkgo v2 deprecation warnings and filtering bug (#420)
f467748 
* Fix for Ginkgo v2 deprecation warnings and filtering bug

* lint

* PR Review and bugfix
@hamadise
small fixes to diagnostic suite (#422)
bac107a
@edcdavid
Fix for duplicate dangling sessions un-expectedly closing (#424)
e532df8 
Fix for duplicate dangling sessions un-expectedly closing
@edcdavid @hamadise
test fix (#427)
283ed35 
Co-authored-by: Salaheddine Hamadi <[email protected]>
@edcdavid @hamadise
Checks if the claim/junit directory exists (#426)
91009fe 
Co-authored-by: Salaheddine Hamadi <[email protected]>
@jc-rh @edcdavid
Fix gitCommit static var (#425)
cb11215 
* Fix gitCommit static var

* Update run-container.sh

Co-authored-by: edcdavid <[email protected]>
@shimritproj @jc-rh
Add SCC capability checks for IPC_LOCK and NET_RAW (#413)
91eee9a 
* Add SCC capability checks for IPC_LOCK and NET_RAW

* fixed make lint

* Updated the file privilegedpod.yml

* fixed make lint

* Resolved comment of Jun

Co-authored-by: Shimrit peretz <[email protected]>
Co-authored-by: Jun Chen <[email protected]>
@hamadise @jc-rh
Add redhat_registry to enable offline run of daemon debug set (#429)
0da5bb3 
Co-authored-by: Jun Chen <[email protected]>
@greyerof @jc-rh
Expecters Sent/Match debug output only when LOG_LEVEL=trace (#407)
4e5aec3 
* Expecters Sent/Match debug output only when LOG_LEVEL=trace

* Proposal to avoid circular dependencies.

Not the most elegant way, though.

Co-authored-by: Jun Chen <[email protected]>
@edcdavid
Adding source for overview.svg picture (#430)
848d7e1
@jc-rh
Removed the unnecessary loop in the session monitoring routine (#431)
4377b44
edcdavid and others added 30 commits March 14, 2022 13:30
@edcdavid
using tar.gz realease to install helm instead of git repo (#652)
24b83c8 
* fix helm

* fix path
@greyerof @sebrandon1
Avoid panic'ing when helm is not installed. (#645)
a2f6cec 
* Avoid panic'ing when helm is not installed.

* Fixed unit test.

Co-authored-by: Brandon Palm <[email protected]>
@edcdavid @sebrandon1
Removing extra statefulset test (#651)
f522a10 
* adjusting min coverage to 20%

* temp

* Removing now extra stateful set step

* Revert "temp"

This reverts commit e421c3c.

Co-authored-by: Brandon Palm <[email protected]>
@dependabot @sebrandon1
Bump google.golang.org/grpc from 1.44.0 to 1.45.0 (#647)
c8e5f85 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.44.0 to 1.45.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.44.0...v1.45.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brandon Palm <[email protected]>
@greyerof @sebrandon1
Added dynamic timeout for the pod-recreation TC. (#646)
89e10ee 
The final timeout for the "oc adm drain" is calculated using this
formula:
timeout = baseTimeout + (numPodsDeployedOnNode * 1min)
where baseTimeout = 5 mins.

Finally, the calculated timeout cannot exceed 30mins.

Also, I've removed the log.Fatal which resulted in the TNF exiting
abruptly when the oc adm drain timed-out, without any possibility
to recover, which was leaving the node cordoned.

Co-authored-by: Brandon Palm <[email protected]>
@greyerof
Get all CSV's installPlans (#649)
82ff9cd 
* Get all CSV's installPlans

As CSV/Operators can be installed through several installPlans, this
PR iterates through all of them saving the needed fields.

* Use empty string instead of null when indexImage not found.

UnitTest has been refactored, but the execCommandOutput function needs
an (ugly) small state machine to control the output at each of the calls
that are made inside the getCsvInstallPlans functions.

* GetCsvInstallPlans refactored.

Now it uses smaller functions for each step.
Added more UTs.
@edcdavid
backporting the log highlighting fix from new repo (#655)
19b7849
@dependabot
Bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (#654)
e22e6b7 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sebrandon1
Bug fix: kernel tainted test did not fail on other types of failures (#…
1aae545 
…653)

* Bug fix: kernel tainted test did not fail on other types of failures

* Add counters

* Address comments
@shimritproj
Adding data about number of container (#658)
97ba55c 
* Adding data about number of container

* Changed function testListenAndDeclared that now run container by container.

* Resolved comments of Gonzalo.

* Back to the old implementation with little changes

* Changed message for the customer

Co-authored-by: Shimrit peretz <[email protected]>
@dependabot @sebrandon1
Bump github.com/onsi/gomega from 1.18.1 to 1.19.0 (#659)
7c47e24 
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.18.1 to 1.19.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.18.1...v1.19.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brandon Palm <[email protected]>
@sebrandon1 @hamadise
Update GolangCI to 1.45.2 (#660)
e982e8b 
Co-authored-by: Salaheddine Hamadi <[email protected]>
@edcdavid
Porting of Fail operator cert test if operator is not certified #95 (#…
d2f531a 
…661)

Porting of Fail operator cert test if operator is not certified
@edcdavid
Fix timeout (#663)
8710512
@greyerof
Bug fix for the NodeSelector handler. (#664)
905f117 
+ Some traces fixed in the networking ts.
@greyerof @hamadise
Diagnostic mode fix: close debug oc sessions before removing node lab… (
fae36e9 
#666)

* Diagnostic mode fix: close debug oc sessions before removing node labels.

This commit tries to fix the crash that happens when running the
container in diagnostic mode: race condition when the program finishes,
as the oc debug session were not closed before the labels are being
removed from the nodes.

* Revert "Fix timeout (#663)"

This reverts commit 8710512.

Co-authored-by: Salaheddine Hamadi <[email protected]>
@greyerof
Timeout for debug pods increased to 5mins. (#669)
9cfa683 
+ Retry interval also increased to 5 secs.
@greyerof @sebrandon1
Container testing log level set to trace. (#665)
4ff1263 
Co-authored-by: Brandon Palm <[email protected]>
@greyerof @sebrandon1
lifecycle's terminationGracePeriod TC removed. (#667)
d6ba0fe 
Due to the issues on both the original and current implementation,
the terminationGracePeriod TC will be removed.

A new and improved version of this TC should be done, checking that
after the configured (or defaulted) value, the pods were removed without
any error code.

Co-authored-by: Brandon Palm <[email protected]>
@shimritproj
Solution for issue on Nokia (#671)
c463484 
* Solution for issue on Nokia

* Fixed the error

Co-authored-by: Your Name <[email protected]>
@sebrandon1
Update Go to 1.17.9 (#668)
873a85e
@sebrandon1
Fix missed version changes (#670)
c239746
@jmontesi
Fix the regex used to parse the sysctl config params (#675)
2b901f3 
Used in test platform-alteration-sysctl-config
@dependabot @sebrandon1
Bump google.golang.org/grpc from 1.45.0 to 1.46.0 (#673)
da1fc1d 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.45.0 to 1.46.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.45.0...v1.46.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brandon Palm <[email protected]>
@sebrandon1
Upgrade Ubuntu release to 22.04 (#676)
3d9ad89
@dependabot
Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 (#680)
9b55232 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump google.golang.org/grpc from 1.46.0 to 1.47.0 (#679)
b754ace 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.46.0 to 1.47.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.46.0...v1.47.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/hashicorp/go-version from 1.4.0 to 1.5.0 (#678)
121c5ea 
Bumps [github.com/hashicorp/go-version](https://github.com/hashicorp/go-version) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/hashicorp/go-version/releases)
- [Changelog](https://github.com/hashicorp/go-version/blob/main/CHANGELOG.md)
- [Commits](hashicorp/go-version@v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-version
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/stretchr/testify from 1.7.2 to 1.7.5 (#683)
f6f45e2 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.7.5.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.2...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sebrandon1
Add deprecation notice
e0dd034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.