Modified dim_calendar_date to accept custom data sources. #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
TDOE required custom data sources for calendar dates, so I have replicated what was shown in dim_class_period to accomplish this.
Breaking changes introduced by this PR:
There should be no breaking changes.
PR Merge Priority:
Changes to existing files:
dim_calendar_date.sql
: modified to look for calendar_date custom data sources variable and then loop through it to include columns in the base model.New files created:
None
Tests and QC done:
Unit tests at TDOE were done and verified as working.
edu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Features
for features, etc.