Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified dim_calendar_date to accept custom data sources. #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smckee-tnedu
Copy link

Description & motivation

TDOE required custom data sources for calendar dates, so I have replicated what was shown in dim_class_period to accomplish this.

Breaking changes introduced by this PR:

There should be no breaking changes.

PR Merge Priority:

  • Low
  • Medium
  • High

Changes to existing files:

  • dim_calendar_date.sql : modified to look for calendar_date custom data sources variable and then loop through it to include columns in the base model.

New files created:

None

Tests and QC done:

Unit tests at TDOE were done and verified as working.

edu_wh PR Review Checklist:

Make sure the following have been completed before approving this PR:

  • Description of changes has been added to Unreleased section of CHANGELOG.md. Add under ## New Features for features, etc.
  • If a new configuration xwalk was added:
    • The code is written such that the xwalk is optional (preferred), and this behavior was tested, OR
    • The code is written such that the xwalk is required, and the required xwalk is added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new xwalk has been added to EDU documentation site here
  • If a new configuration variable was added:
    • The code is written such that the variable is optional (preferred), and this behavior was tested, OR
    • The code is written such that the variable is required, and a default value was added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new variable has been added to EDU documentation site here
  • Reviewer confirms the grain of all tables are unchanged, OR any changes are expected, communicated, and this PR is flagged as a breaking change (not for patch release)

@ejoranlienea
Copy link
Contributor

Looks great, but I see there are some Databricks/Snowflake syntax differences around dates. This package looks like it can already handle all that, so maybe we add that to the packages and then use those macros for dayname and weekofyear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants