Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fct_stu_contact_information #115

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

keenzarate213
Copy link
Contributor

No description provided.

models/core_warehouse/fct_student_contact_information.sql Outdated Show resolved Hide resolved
models/core_warehouse/fct_student_contact_information.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_student.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_student.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_student.sql Outdated Show resolved Hide resolved
make language configurable, widen contact data before joining with dim student in fct_stu_contact_info
dbt_project.yml Outdated Show resolved Hide resolved
models/core_warehouse/dim_student.sql Outdated Show resolved Hide resolved
keenzarate213 and others added 3 commits March 15, 2024 13:40
adjust default order_by in get_column_values, switch bld language to wide instead of choosing preference, and adjust yml to list language to allow multiple
include zip code, latitude, long, city, etc
@rlittle08 rlittle08 changed the title Feature/add stu lang address fct_stu_contact_informatino Mar 24, 2024
@rlittle08 rlittle08 changed the title fct_stu_contact_informatino fct_stu_contact_information Mar 24, 2024
@rlittle08
Copy link
Collaborator

rlittle08 commented Mar 25, 2024

one major TODO: how to deal with the potential case that e.g. address types & language types might overlap? Currently, this would cause duplicate colnames in fct_student_contact_information, which causes SQL error. I can't yet think of a quick way to handle this case.

A similar but less threatening case is e.g. language types that aren't specific enough. One of the Ed-Fi defaults for Language Use is 'Other', and this is pop'd in Boston, so fct_student_contact_information ends up with a column just called other. Not descriptive. Should we have some way of creating configurable aliases in the bld_ef3__student_wide.. tables, which might resolve both these issues?

I think these would both be fixed by including suffix='_language' in bld_ef3__student_wide_languages, BUT this was probably left out initially bc most of the language descriptors end in _language. So we probably want some code to handle this, i.e. replace _language_language with _language or something. Looks like this would also be applicable in less frequent address types, e.g. "Father Address"

@rlittle08 rlittle08 marked this pull request as ready for review March 25, 2024 22:29
@rlittle08
Copy link
Collaborator

Marking this back to draft while we figure out best path forward

@rlittle08 rlittle08 marked this pull request as draft March 27, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants